fix: thread the owning page into icon and UniqueID calls (render-once D8)#165
Merged
Merged
Conversation
Direct calls into mod-fontawesome's assets/icon.html and mod-utils' utilities/UniqueID.html now pass the resolved page, so sprite symbols and id counters land on the owning page even when the content renders in a foreign context (search index walk, RSS feed embedding). go.mod raises the mod-fontawesome floor to v6.1.1, whose icon schema accepts the optional 'page' argument (older schemas reject it). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
🎉 This PR is included in version 2.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render-once program — flip unblock, mod-blocks side
Threads the owning page into the direct
assets/icon.htmlcalls (testimonial-carousel,preview incl. the device-button inline partial) and all 4
utilities/UniqueIDcallers(faq, panels, testimonial-carousel, preview) — foreign-context
.Contentrenders otherwiseregister sprite symbols / UIDs on the wrong page (7-page dangling-sprite class found by the
flip gate; the UniqueID side is a latent hazard today).
go.mod floors mod-fontawesome at v6.1.1 (the args engine hard-errors on unknown named
args; FA v6.0.2's icon schema lacks
page) — MVS guarantees the accepting schema on everyreleased stack. Attributed drag: mod-utils v6.5.0→v6.5.1 + FortAwesome snapshot; nothing else.
Gate (hinode exampleSite @ 50b5612b, staged control/candidate builds): 0 ERROR, 98/26/24,
WARN parity; all comparisons show only the 3 known racy RSS files (pre-existing hinode-side
race, fixed on the held flip branch); candidate sprite audit: 0 dangling refs; no UID
renumbering pre-flip. Suites green. Independently reviewed by the program driver.
Deferred (documented): 5 indirect calls into hinode partials whose released schemas lack
page(onlymagazine.html:85is icon-relevant) — post-hinode-release follow-up.🤖 Generated with Claude Code