fix(blocks): drop dangling ARIA on preview fallback panes#161
Merged
Conversation
Every tab pane emitted role=tabpanel and aria-labelledby pointing at a tab button, but the button group is only rendered when not in fallback mode. In fallback (no url, or a CSP-blocked host) the pane is plain content, so the reference dangled. Gate both attributes on not showFallback.
Contributor
Author
|
🎉 This PR is included in version 2.1.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every preview tab pane emitted
role="tabpanel"andaria-labelledby="{{ $id }}-{{ $device }}-tab", unconditionally. But the device button group that mints those-tabcontrol ids is rendered only when not in fallback mode. In fallback (nourl, or a CSP-blocked iframe host) there is no button group, so every pane'saria-labelledbypointed at a non-existent id androle="tabpanel"described a tab with no control.Both attributes are now gated on
not $showFallback— in fallback the pane is plain content, not a tab panel. The normal tabbed path is unchanged. Verified against the Hinode exampleSite: noaria-labelledbydangles in fallback mode, and the check was confirmed to fail on the pre-fix code.Independent of the companion PRs.
🤖 Generated with Claude Code