fix: thread owning page and embed flag into bookshop content blocks (render-once D4)#2038
Merged
Merged
Conversation
The example-bookshop shortcode injects the owning page (_page) into the component data, and docs/all.html passes the embed flag to page/blocks.html as an explicit argument. The deprecated blocks_embed scratch seed stays for one release to support module version skew. Requires mod-blocks v2.2.0. Part of the render-once program (slice D4). Note: threading _page through example-bookshop stabilizes foreign-context .Content renders; search-index and 404 bytes change accordingly (see program register). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Required by the _page/embed prop threading in this branch; the legacy page/blocks.html signature cannot accept the new dict argument. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for gethinode-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Jul 16, 2026
Collaborator
Author
|
🎉 This PR is included in version 3.2.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render-once program — slice D4, hinode side (HELD for maintainer review)
Part of the Hinode render-once implementation program (design:
gethinode.com
docs/superpowers/specs/2026-07-15-content-render-once-design.md§4.2/§6-D4).Companion to gethinode/mod-blocks#163 (merged, released as v2.2.0).
Changes
_shortcodes/example-bookshop.html— merges"_page" .Pageinto the component dict, sobookshop components rendered from page content use the owning page instead of the ambient
global (which resolves to the triggering page in foreign-context
.Contentrenders).layouts/docs/all.html— passes(dict "page" . "embed" true)topage/blocks.html(mod-blocks ≥2.2.0 signature); the
blocks_embedScratch seed stays for one release(removed in D9).
go.mod— mod-blocks v2.1.4 → v2.2.0 (required: the legacypage/blocks.htmlcannot acceptthe dict signature). No other version movement (MVS verified).
Expected diffs (maintainer-accepted 2026-07-16) — all deterministic render-once fixes
Candidate-vs-stock differs in 83 files, classified exhaustively:
records the owning page's breadcrumb in the
docs/blocks/heroexamples instead of the 404page's (the 404's card list used to win the
.Contentrace), which changes the embeddedsearch-index bundle bytes → new fingerprint in every EN page.
Included:
en/404.htmladditionally stops loading a straysimple-datatablesscript thatwas registered on it by a foreign-context render (class-c3 fix).
en/docs/blocks/list/index.html— the documented UID pair shift(
table-filter-UID-1→UID-2, class-c6; ids stay internally consistent).Run-vs-run is clean on both sides (allowlisted RSS files only); 0 ERROR; 98/26/24 pages; WARN
set unchanged; no latent AddModule warnings. Re-verified by the program driver against the
released v2.2.0 (byte-identical to the replacement-based gate).
🤖 Generated with Claude Code