Repository navigation
SDKS-4855: fix update-check tests in the release workflow - #8
Merged
Merged
Conversation
Remove the global update-check override that breaks unit tests. Add an explicit bootstrap workflow that tests the unchanged release commit and publishes GitHub assets using GITHUB_TOKEN, without npm or cross-repository credentials. Co-Authored-By: Codex <noreply@openai.com>
Remove the completed one-time Homebrew publishing workflow and its dispatch input. The final diff only removes the global update-check opt-out that broke two unit tests. Co-Authored-By: Codex <noreply@openai.com>
Aaron LaBeau (biozal)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release runs set
DITTOSH_NO_UPDATE_CHECK=1globally, causing two unit tests to fail when they exercise the enabled update-check behavior. Remove that workflow-wide override so the unit and coverage suites run with their expected environment. Release smoke tests already disable update checks in their own subprocess environment.The final diff is one line removed from
.github/workflows/release.yml.Validation: all 570 unit tests passed with
RELEASE_TAG=v0.1.0, including the update-banner and opt-out tests; actionlint and diff checks passed.Related: SDKS-4855.