Stop Codex inference reads at SSE completion - #4830
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 SLOP COP 🚨 ·
new-issue-autopilotHuman comments
What was wrong
The Codex inference SSE reader stored completed output but continued reading until transport EOF. It ignored
[DONE]as well, so a successfully completed response with an open body became a deadline failure. This source defect is reproduced twice on trustedorigin/main; attribution of the original live naming timeout remains unverified.Report: https://get-bb.github.io/reports/issues/4828.html
What changed
response.completed,response.done, or[DONE]and best-effort cancel the remaining body.How you verified
pnpm exec turbo run test --filter=bb-plugin-provider-codex -- src/ai/chatgpt-client.test.tsfails in six regression cases withcodex_request_timeout; 17 existing cases pass. A second clean checkout at76a1ebcaf5fa038d8638daaad7aad3dafe2ae709repeats the same failures.pnpm exec turbo run test typecheck lint --filter=bb-plugin-provider-codexpasses: 341 tests across 32 files, typecheck, and lint.pnpm exec oxfmt --check plugins/provider-codex/src/ai/chatgpt-client.ts plugins/provider-codex/src/ai/chatgpt-client.test.tspasses.git diff --checkpasses;git diff --numstat origin/mainconfirms 102 changed text lines and no binary changes.Fixes #4828