Send the full task to the thread title service - #4829
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Thread title generation sent the AI title service the same 80-column string bb uses as the fallback title, so the task was cut to 80 display columns before inference. This has been true since title generation moved to the templates package in March; #3887 kept the clamp when it split out invoked commands. Anything after the first ~80 characters never reached the model, so it guessed. In Cole's #bugs report, the model only got this:
The thread was titled "Add back-button navigation to plan graph tools", even though the request was for a burndown chart.
What changed
apps/server/src/services/threads/title-generation.ts: the title service now receives the full cleaned task (from Cole's Fix thread title generation truncating task context #4827, which was auto-closed by the contributor allowlist). It is capped at 4000 display columns so a huge paste can't make titling slow or expensive. Fallback titles still fit 80 columns, and generated titles still fit 48.generate-thread-metadata.md: updated thecleanedPromptvariable description.How you verified
Remote CI (
@bb/servertitle-generation suites). The new burndown and long-skill-name cases fail onmain, where the task is cut at 80 columns. The cap test covers a 10,000-character paste.Original fix by @its-rosetta in #4827.
BB-Thread-ID: thr_a4y66pq7d2
🤖 Generated with Claude Code