Repository navigation
Backport optional putRecord/deleteRecord commit to 0.5.2 - #80
Merged
Merged
Conversation
The lexicons require only uri and cid on putRecord/createRecord output and nothing on deleteRecord output. A PDS omits commit when the write is a no-op (identical record, or deleting a missing record), so commit is now optional. validationStatus is optional and an open knownValues string. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> (cherry picked from commit 8d809ff)
The test fixture came from 0.8.0's PutRecordSwapEncodingTests and its GermConvenienceHTTP import from 0.6.1; inline the fixture and drop the import. Adds the rsky shape (uri + cid only, on every write), which is what breaks Blacksky accounts. Changeset folded into CHANGELOG by hand: release automation only runs from main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #75 (
8d809ff, shipped in 0.10.0) onto 0.5.1 so the iOS app can take it without the 0.6–0.10 dependency cascade (GermConvenience 0.8, swift-crypto 5, theverifyRecordProofAPI change).Why now: rsky, Blacksky's PDS, returns only
{cid, uri}from everyputRecord, nevercommit. Under 0.5.1 every declaration write from a Blacksky account lands on the PDS but throwskeyNotFound("commit")in the client. The app then never marks the card set up: it shows the inbox as "Nobody", never runs maintenance (so no mutuals and no PQ key package), and nags the user to log in again (GER-3537/3538/3541).Changes beyond the cherry-pick:
Thingfixture. It previously borrowed it from 0.8.0'sPutRecordSwapEncodingTests.GermConvenienceHTTPimport.main.To release: merge into
release/0.5, then tag the merge commitv0.5.2. The branch is not meant to merge back intomain.Tested locally:
swift testpasses all 83 + 64 tests, andswift format lint --strictis clean. Every downstream package pins AtprotoTypes withfrom:, so 0.5.2 resolves everywhere.🤖 Generated with Claude Code