Skip to content

Backport optional putRecord/deleteRecord commit to 0.5.2 - #80

Merged
anna-germ merged 2 commits into
release/0.5from
anna/backport-optional-write-commit
Nov 14, 2026
Merged

anna-germ merged 2 commits into
release/0.5from
anna/backport-optional-write-commit

Conversation

@anna-germ

Copy link
Copy Markdown
Contributor

Backports #75 (8d809ff, shipped in 0.10.0) onto 0.5.1 so the iOS app can take it without the 0.6–0.10 dependency cascade (GermConvenience 0.8, swift-crypto 5, the verifyRecordProof API change).

Why now: rsky, Blacksky's PDS, returns only {cid, uri} from every putRecord, never commit. Under 0.5.1 every declaration write from a Blacksky account lands on the PDS but throws keyNotFound("commit") in the client. The app then never marks the card set up: it shows the inbox as "Nobody", never runs maintenance (so no mutuals and no PQ key package), and nags the user to log in again (GER-3537/3538/3541).

Changes beyond the cherry-pick:

  • The test now has its own Thing fixture. It previously borrowed it from 0.8.0's PutRecordSwapEncodingTests.
  • Removed the 0.6.1-only GermConvenienceHTTP import.
  • Added a test for rsky's exact reply shape.
  • Bumped the version to 0.5.2 and wrote the CHANGELOG entry by hand, because release automation only runs on main.

To release: merge into release/0.5, then tag the merge commit v0.5.2. The branch is not meant to merge back into main.

Tested locally: swift test passes all 83 + 64 tests, and swift format lint --strict is clean. Every downstream package pins AtprotoTypes with from:, so 0.5.2 resolves everywhere.

🤖 Generated with Claude Code

germ-mark and others added 2 commits November 13, 2026 15:37
The lexicons require only uri and cid on putRecord/createRecord output and
nothing on deleteRecord output. A PDS omits commit when the write is a no-op
(identical record, or deleting a missing record), so commit is now optional.
validationStatus is optional and an open knownValues string.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 8d809ff)
The test fixture came from 0.8.0's PutRecordSwapEncodingTests and its
GermConvenienceHTTP import from 0.6.1; inline the fixture and drop the
import. Adds the rsky shape (uri + cid only, on every write), which is what
breaks Blacksky accounts. Changeset folded into CHANGELOG by hand: release
automation only runs from main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8fc88ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@anna-germ
anna-germ merged commit 45e282c into release/0.5 Nov 14, 2026
7 checks passed
@anna-germ
anna-germ deleted the anna/backport-optional-write-commit branch November 14, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants