Implement mod statuses - #89
Open
qimiko wants to merge 4 commits into
Open
Conversation
qimiko
marked this pull request as ready for review
August 7, 2026 20:10
Fleeym
reviewed
Aug 8, 2026
|
|
||
| alter table mods | ||
| add column status mod_status not null default 'default', | ||
| add column status_info text, |
Member
There was a problem hiding this comment.
It's a bit redundant to have status stuff here too, since we already store the info in mod_status_logs. The way I'd handle it is have one single FK to mod_status_logs which denotes the "active" status, and the others are for historic purposes.
Fleeym
reviewed
Aug 8, 2026
| &mut tx, | ||
| ).await?; | ||
|
|
||
| Mod::create_mod_status_log( |
Member
There was a problem hiding this comment.
ideally this should be moved in database::repository::mods instead of keeping it as a Mod impl
Fleeym
reviewed
Aug 8, 2026
| let direct_search = search_str.as_ref().is_some_and(|x| !x.is_empty()) || developer.is_some(); | ||
| if !direct_search { | ||
| // hide archived mods from direct search | ||
| builder.push(" AND m.status <> 'archived'"); |
Member
There was a problem hiding this comment.
This might be a bit weird for UX: a user sees the mod normally when looking through the pages, but when searching that mod suddenly dissapears. We'd have to display this well in the UI, otherwise it could come across as a bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the mod status can have more effects than a tag, which is why this isn't just rolled into the tags system. a mod's status can be updated by index admins and the mod's developers, but only index admins can add a note to the status and lock it from changes by the mod developers. notes are public, but clients will likely only display them for archived mods