Skip to content

fix: stop required checks staying pending for dependabot PRs - #60

Merged
ltclm merged 1 commit into
masterfrom
bug/dependabot-required-checks-pending
Sep 17, 2026
Merged

ltclm merged 1 commit into
masterfrom
bug/dependabot-required-checks-pending

Conversation

@ltclm

@ltclm ltclm commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

@ltshb Sorry for the back-and-forth! This solution seems to work now. I manually updated this PR to use the GitHub Action branch, and all tests are passing: https://github.com/geoadmin/bgdi-scripts/pull/2533

Skipping the pr-content.yml caller job with an if condition prevented the reusable workflow from ever starting, so its required child checks (Validate PR title, Validate PR description, Validate commit messages) never reported a status and stayed pending indefinitely on Dependabot PRs.

The dependabot skip is now applied inside each job of pr-content.yml instead, so the jobs still run and report a completed (skipped) status, and the caller workflows no longer skip the content job itself.

Skipping the pr-content.yml caller job with an if condition prevented the reusable workflow from ever starting, so its required child checks (Validate PR title, Validate PR description, Validate commit messages) never reported a status and stayed pending indefinitely on Dependabot PRs.

The dependabot skip is now applied inside each job of pr-content.yml instead, so the jobs still run and report a completed (skipped) status, and the caller workflows no longer skip the content job itself.
@github-actions github-actions Bot added the bug Something isn't working as expected label Sep 17, 2026
@ltclm
ltclm requested a review from ltshb September 17, 2026 06:34

@ltshb ltshb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 It is good for geoadmin, but I think we should keep it as is for swissgeo as we don't use github dependabot in swissgeo and we will probably use renovate only in future.

@ltclm
ltclm merged commit 668b95d into master Sep 17, 2026
15 checks passed
@ltclm
ltclm deleted the bug/dependabot-required-checks-pending branch September 17, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants