Fix the 0/1 values of VDMA_LEN_YES/NO, now VDMA_LEN_ACTIVE/INACTIVE - #94
Merged
Conversation
This avoids confusion over unmarked Boolean values, and allows their old (mistaken) names to be supported by hardware_compat.inc.
Rangi42
changed the title
VDMA_LEN_YES/NOVDMA_LEN_YES/NO, now VDMA_LEN_ACTIVE/INACTIVE
Collaborator
Author
|
Thanks to @pinobatch for noticing this. The mistake stems from when " |
avivace
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80, though I'm also looking into the other points brought up in its comments.