Make error message for Group([]) more helpful - #6511
Open
limakzi wants to merge 1 commit into
Open
Conversation
limakzi
added
kind: bug
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6511 +/- ##
=======================================
Coverage 78.91% 78.91%
=======================================
Files 685 685
Lines 294163 294187 +24
Branches 8669 8669
=======================================
+ Hits 232147 232169 +22
Misses 60215 60215
- Partials 1801 1803 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fingolfin
reviewed
Aug 15, 2026
Comment on lines
+4951
to
+4952
| ErrorNoReturn("an empty list of generators is not supported, ", | ||
| "the identity element must be given as second argument"); |
Member
There was a problem hiding this comment.
But it is supported, just not alone...
fingolfin
reviewed
Aug 15, 2026
Comment on lines
+5133
to
+5134
| "Group(<gens>) with an empty list <gens> is not supported, ", | ||
| "use Group(<gens>,<id>) to specify the identity element <id>"); |
fingolfin
changed the title
Group([]) more helpful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Groupwith an empty list of generators (#6499)Group([])failed with the generic usage error, which listedGroup(<gens>)as valid and gave no hint that the identity element is required. The one-argument operations were worse:GroupWithGenerators([])reported no method found, andGroupWithGenerators("")silently returned a group with no identity that only broke later.