Skip to content

Download: tolerate a curlInterface that honours 'target' itself #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fingolfin wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Download: tolerate a curlInterface that honours 'target' itself #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/download.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,11 @@ Add( Download_Methods, rec(
res:= ValueGlobal( "DownloadURL" )( url, opt );

if res.success = true and
IsBound( opt.target ) and IsString( opt.target ) then
IsBound( opt.target ) and IsString( opt.target ) and
IsBound( res.result ) then
# 'DownloadURL' ignored 'target' and returned the contents, so write
# them out here. A curlInterface that honours 'target' itself returns
# no 'result', and then the file was never held in memory at all.
FileString( opt.target, res.result );
Unbind( res.result );
fi;
Expand Down