Download: do not modify the caller's options record - #102
Conversation
Filling in the defaults for 'verifyCert' and 'maxTime' wrote into the record the caller passed in, so a record reused across several calls kept the settings from the first one. Only visible when the preferences differ from their defaults -- with the shipped values neither branch is taken -- which is why the test sets DownloadMaxTime first. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 86.24% 86.30% +0.05%
==========================================
Files 32 32
Lines 1905 1906 +1
==========================================
+ Hits 1643 1645 +2
+ Misses 262 261 -1
🚀 New features to boost your workflow:
|
ThomasBreuer
left a comment
ThomasBreuer
left a comment
There was a problem hiding this comment.
Looks good, thanks.
|
As I have no idea what these four PRs are doing, @fingolfin cannot really be requesting a review by me, so I am inclined to think this is a request to merge all four, which I will do this afternoon if there are no further instructions. |
|
@cdwensley thank you. But upon reflection let me double check each of those again |
|
Last week I was a conference and went a bit overboard with allowing my AI to open PRs without me double checking everything. That was a mistake and I apologize if I wasted anyone's time by having them stare at slop. (The "reviewed by me" was inserted by the AI without consulting with me -- but I should have caught it. Argh). Anyway: I've marked this PR as "draft" for now, please don't merge it -- I'll carefully review and edit it, and will mark it as "ready for review" once I am satisfied. Don't waste your time on it for now (that said, of course you are welcome to leave feedback, but don't feel obliged to). |
4 participants
Downloadfills in the defaults forverifyCertandmaxTimeby writing into the record the caller passed, so a record reused across calls keeps the first call's settings.Let's not do that.
Written with Claude Opus 5 via Claude Code.