Use SmallGroupsAddLayer where SmallGrp offers it - #58
Merged
Conversation
SmallGrp 1.7 takes a layer as a record and places it itself, so the two slot numbers and the six array assignments are no longer ours to get right. The old route stays for SmallGrp before 1.7, chosen by IsBound. SOTGRPS_LAYER and SOTGRPS_POS exist only on that old route now; nothing outside gap/Integration.gi read them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 98.39% 98.13% -0.26%
==========================================
Files 22 22
Lines 8096 8118 +22
==========================================
+ Hits 7966 7967 +1
- Misses 130 151 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
integration.tst calls SmallGroupsInformation and pins its whole output, including the closing line, which SmallGrp 1.7 changes: a layer registered through SmallGroupsAddLayer has no number to print, so it is named instead. No one expectation file suits both versions. The file is now written for 1.7, and testall.g passes a transformFunction mapping the older wording onto it, so the suite passes either way. That shim goes when SmallGrp 1.7 becomes the requirement. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
fingolfin
force-pushed
the
worktree-addlayer
branch
from
August 16, 2026 15:22
865a124 to
e1630ec
Compare
The minimal CI job ran GAP 4.11.1, whose Test copies unknown options into its record and never reads them, so the mapping of SmallGrp's older wording onto the newer one was silently dropped there and integration.tst failed six times. transformFunction arrived in GAP 4.12. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
fingolfin
force-pushed
the
worktree-addlayer
branch
from
August 17, 2026 07:06
0bf5fc1 to
0d31e7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SmallGrp 1.7 takes a layer as a record and places it itself, so the two slot numbers and the six array assignments are no longer ours to get right. The old route stays for SmallGrp before 1.7, chosen by
IsBound.SOTGRPS_LAYERandSOTGRPS_POSexist only on that old route now; nothing outsidegap/Integration.giread them.Co-Authored-By: Claude Opus 5 noreply@anthropic.com