Repository navigation
Fix checkequal and lastfailure - #14
Merged
Merged
Conversation
The skip check tested the left-hand result twice, so a QC_Skip from the right-hand function was compared as an ordinary value and reported as a failure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
QC_ListOf and QC_SetOf chose their length with the global random source, and the IsDigraph generator used RandomDigraph, which cannot be given a random source. Changing the global random state therefore changed the values QC_Check generated for a fixed seed. The IsDigraph generator now builds its edges from the given random source. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
QC_LastFailure returned the arguments of the last test run, even when that test passed, and returned the arguments after the tested function had a chance to modify them. It returned fail rather than the documented false when nothing had failed, and after QC_CheckEqual it returned an internal wrapper rather than the documented funcs. Each call to QC_Check or QC_CheckEqual now clears it, and sets it only if the check fails on a particular input, recording the unmodified arguments. QC_RerunLastFailure reruns on a copy of those arguments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
QC_Skip, QC_RegisterFilterGen and the QC_ListOf family were plain global assignments, so user code could overwrite them by accident. QC_Skip is now also immutable, as a test compares results against it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
QC_Skip was the string "SKIP TEST" and was compared with =, so a tested function which genuinely returned that string was treated as skipped. It is now the only object of its own family, and is compared with IsIdenticalObj. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
These were only mentioned in the tutorial. QC_Skip is now declared with DeclareGlobalName so AutoDoc documents it as a variable, which needs AutoDoc 2026.03.17. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
QC_LastFailure, QC_RerunLastFailure and QC_GetConfig were shown as taking an argument, QC_SetConfig did not list the ramp and catchErrors options, and the tutorial referred to a nonexistent QC_Equal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14 +/- ##
==========================================
+ Coverage 84.87% 94.44% +9.56%
==========================================
Files 4 4
Lines 205 216 +11
==========================================
+ Hits 174 204 +30
+ Misses 31 12 -19
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.