Repository navigation
Document DirectProduct and SemidirectProduct - #213
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
=======================================
Coverage 67.72% 67.72%
=======================================
Files 88 88
Lines 12914 12914
=======================================
Hits 8746 8746
Misses 4168 4168 🚀 New features to boost your workflow:
|
fingolfin
reviewed
Oct 8, 2026
Comment on lines
+538
to
+544
| <ManSection> | ||
| <Oper Name="SemidirectProduct" Arg="G, alpha, N" Label="for pcp groups"/> | ||
| <Description> | ||
| returns the semidirect product of the pcp-groups <A>G</A> and <A>N</A>, | ||
| where <A>G</A> acts on <A>N</A> via <A>alpha</A>, as a pcp-group. | ||
| </Description> | ||
| </ManSection> |
Member
There was a problem hiding this comment.
Could you add an example for this? In my experience figuring out how to get a suitable alpha is the hardest bit of using SemidirectProduct (in general, also in the GAP library) and an example helps users tremendously.
Collaborator
Author
There was a problem hiding this comment.
I added the construction of the Klein bottle group, think that's sufficient, or is it too trivial?
fingolfin
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #212. Not sure if this is the correct/best place to put this in the documentation.