Repository navigation
Fix a bug in cohomology calculations - #169
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 67.72% 67.75% +0.02%
==========================================
Files 88 88
Lines 12914 12913 -1
==========================================
+ Hits 8746 8749 +3
+ Misses 4168 4164 -4
🚀 New features to boost your workflow:
|
stertooy
marked this pull request as ready for review
October 7, 2026 13:51
fingolfin
approved these changes
Oct 8, 2026
fingolfin
left a comment
Member
There was a problem hiding this comment.
I took the liberty of rebasing this on latest master, so that the diff became small.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #211. Built on top of #210.
The old condition was meant to check if "conjugation by the inverse of a generator" works correctly, by confirming it's the inverse operation by the (already verified) "conjugation by a generator". It checked this by testing$(x^y)^{y^{-1}} = x$ for generators $x,y$ .
However, conjugating$x^y$ by $y^{-1}$ means we interpret $x^y$ as a word, and apply "conjugation by $y^{-1}$ " to each of the generators appearing in this word. This means it might use the same relation multiple times, and an error in the tail could then appear an even number of times, so mod 2 it would disappear and pass the check.
Now, we instead check that$(x^{y^{-1}})^y = x$ (or rather $(x^{y^{-1}})y = yx$ ). Since we apply "conjugation by an inverse" to a single generator instead of a word, we can't have multiple errors cancelling out each other.
AI Disclosure: bug was discovered by GPT-6 Astra during a package audit.