Fix inverted verifyCert check which disabled TLS certificate verification by default - #63
Open
fingolfin wants to merge 2 commits into
Open
Fix inverted verifyCert check which disabled TLS certificate verification by default#63fingolfin wants to merge 2 commits into
verifyCert check which disabled TLS certificate verification by default#63fingolfin wants to merge 2 commits into
Conversation
The block disabling CURLOPT_SSL_VERIFYPEER and CURLOPT_SSL_VERIFYHOST ran when verifyCert was true, so the default settings turned TLS verification off, while verifyCert := false left it on. Fixes #61 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Runs `openssl s_server` with a freshly generated self-signed certificate, and checks that the download fails by default and succeeds only with verifyCert := false. Skipped if openssl is not available. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
========================================
+ Coverage 95.3% 96.0% +0.6%
========================================
Files 3 3
Lines 152 152
Branches 15 15
========================================
+ Hits 145 146 +1
Misses 3 3
+ Partials 4 3 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The block disabling
CURLOPT_SSL_VERIFYPEERandCURLOPT_SSL_VERIFYHOSTranwhen
verifyCertwas true. So the default settings turned TLS verificationoff, and
verifyCert := falseleft it on.Adds a test that serves HTTPS from
openssl s_serverwith a freshly generatedself-signed certificate and checks that the download fails by default and
succeeds only with
verifyCert := false. It is skipped where openssl ismissing. With the old condition restored it reports
[ true, false ]insteadof
[ false, true ].Fixes #61
Co-Authored-By: Claude Opus 5 noreply@anthropic.com