Fix AffineNormalizer returning a proper subgroup - #62
Merged
Conversation
The stabilizer computation dropped the Schreier generators rep[p]*g*rep[p^g]^-1, so groups such as Pc lost part of their affine normalizer. While at it, also improve the orbit algorithm: instead of searching linearly, use binary search. Fixes #60 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 94.68% 94.81% +0.12%
==========================================
Files 24 24
Lines 7524 7537 +13
==========================================
+ Hits 7124 7146 +22
+ Misses 400 391 -9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stabilizer computation dropped the Schreier generators rep[p]grep[p^g]^-1, so groups such as Pc lost part of their affine normalizer.
While at it, also improve the orbit algorithm: instead of searching linearly, use binary search.
Fixes #60
Co-Authored-By: Claude Opus 5 noreply@anthropic.com