Skip to content

Ask for person GitHub usernames - #78

Merged
fingolfin merged 3 commits into
gap-packages:masterfrom
lgoettgens:lg/githubusername
Aug 16, 2026
Merged

Ask for person GitHub usernames#78
fingolfin merged 3 commits into
gap-packages:masterfrom
lgoettgens:lg/githubusername

Conversation

@lgoettgens

@lgoettgens lgoettgens commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Part of resolving gap-system/gap#4784. This should be merged if and only if gap-system/gap#6497 is merged.

Summary

  • reject GitHub usernames entered as profile URLs or @ mentions
  • ask for GitHubUsername in wizard person records
  • include the new person field in the generated package fixture

Created using Codex (GPT-5.5) codex@openai.com

lgoettgens and others added 2 commits August 11, 2026 12:50
Co-authored-by: Codex (GPT-5.5) <codex@openai.com>
Co-authored-by: Codex (GPT-5.5) <codex@openai.com>
@lgoettgens
lgoettgens marked this pull request as ready for review August 11, 2026 11:00
Co-authored-by: Codex (GPT-5.5) <codex@openai.com>
@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 32.50000% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.29%. Comparing base (ae42399) to head (ef3c479).

Files with missing lines Patch % Lines
gap/input.g 30.76% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   68.02%   67.29%   -0.73%     
==========================================
  Files           9        9              
  Lines         985     1006      +21     
==========================================
+ Hits          670      677       +7     
- Misses        315      329      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread gap/input.g
return Concatenation(
"The name must be nonempty, consist of alphanumerical ",
"characters or '-', and must not start with '-'." );
return "The GitHub username must be a valid GitHub username.";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks as if it makes the GitHub user name mandatory? I definitely don't want -- e.g. someone may not even have a GitHub user account. Or they simply don't want to get notifications when a package update is found by the package distro.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does look so at a first glance, but that's not the case. The actual wizard code only calls the verification function in cases where the user supplied anything else than an empty string. If the user gave an empty string, then instead the field is just put in a comment line of the resulting PackageInfo.g file. This functionality already exists for PostalAddress, website,...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK great then!

@fingolfin
fingolfin merged commit 6f8f7d4 into gap-packages:master Aug 16, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants