Ask for person GitHub usernames - #78
Conversation
Co-authored-by: Codex (GPT-5.5) <codex@openai.com>
Co-authored-by: Codex (GPT-5.5) <codex@openai.com>
Co-authored-by: Codex (GPT-5.5) <codex@openai.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 68.02% 67.29% -0.73%
==========================================
Files 9 9
Lines 985 1006 +21
==========================================
+ Hits 670 677 +7
- Misses 315 329 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| return Concatenation( | ||
| "The name must be nonempty, consist of alphanumerical ", | ||
| "characters or '-', and must not start with '-'." ); | ||
| return "The GitHub username must be a valid GitHub username."; |
There was a problem hiding this comment.
This looks as if it makes the GitHub user name mandatory? I definitely don't want -- e.g. someone may not even have a GitHub user account. Or they simply don't want to get notifications when a package update is found by the package distro.
There was a problem hiding this comment.
It does look so at a first glance, but that's not the case. The actual wizard code only calls the verification function in cases where the user supplied anything else than an empty string. If the user gave an empty string, then instead the field is just put in a comment line of the resulting PackageInfo.g file. This functionality already exists for PostalAddress, website,...
Part of resolving gap-system/gap#4784. This should be merged if and only if gap-system/gap#6497 is merged.
Summary
@mentionsGitHubUsernamein wizard person recordsCreated using Codex (GPT-5.5) codex@openai.com