Skip to content

Rm unused gv funcs - #124

Merged
james-d-mitchell merged 4 commits into
gap-packages:mainfrom
james-d-mitchell:rm-unused-gv-funcs
Oct 16, 2026
Merged

james-d-mitchell merged 4 commits into
gap-packages:mainfrom
james-d-mitchell:rm-unused-gv-funcs

Conversation

@james-d-mitchell

@james-d-mitchell james-d-mitchell commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

This PR removes the declarations of all functions not used outside of gv.gi from gv.gd and BIndGlobals them in gv.gi instead. Should only be merged after #121

@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.40%. Comparing base (adb1bc5) to head (3dd8ca0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   94.43%   96.40%   +1.96%     
==========================================
  Files          12       12              
  Lines        1223     1167      -56     
==========================================
- Hits         1155     1125      -30     
+ Misses         68       42      -26     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@james-d-mitchell
james-d-mitchell merged commit 8bba23d into gap-packages:main Oct 16, 2026
8 checks passed
@james-d-mitchell
james-d-mitchell deleted the rm-unused-gv-funcs branch October 16, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant