Skip to content

fix(sms): various code fixups #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nijel merged 4 commits into from
Jul 28, 2026
Merged

fix(sms): various code fixups #328

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63cb32a
Apply suggested fix to gammu/src/convertors/sms.c from Copilot Autofix
nijel Jul 28, 2026
cc247c6
Apply suggested fix to gammu/src/convertors/sms.c from Copilot Autofix
nijel Jul 28, 2026
89f048c
Apply suggested fix to gammu/src/convertors/sms.c from Copilot Autofix
nijel Jul 28, 2026
602ff01
Merge branch 'master' into ai-findings-autofix/gammu-src-convertors-s…
nijel Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions gammu/src/convertors/sms.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,16 @@ char *SMSValidityToString(GSM_SMSValidity Validity)
if (Validity.Relative == SMS_VALID_Max_Time) {
strcpy(s, "Max");
} else if (Validity.Relative <= 143) {
snprintf(s, 99, "%dM",
snprintf(s, sizeof(s) - 1, "%dM",
5 * (1 + Validity.Relative));
} else if (Validity.Relative <= 167) {
snprintf(s, 99, "%dM",
snprintf(s, sizeof(s) - 1, "%dM",
12 * 60 + 30 * (Validity.Relative -
143));
} else if (Validity.Relative <= 196) {
snprintf(s, 99, "%dD", Validity.Relative - 166);
snprintf(s, sizeof(s) - 1, "%dD", Validity.Relative - 166);
} else {
snprintf(s, 99, "%dW", Validity.Relative - 192);
snprintf(s, sizeof(s) - 1, "%dW", Validity.Relative - 192);
}
break;
default:
Expand Down Expand Up @@ -214,7 +214,7 @@ GSM_SMSFormat StringToSMSFormat(char *s)
else if (strcmp("Email", s) == 0)
return SMS_FORMAT_Email;
else {
PyErr_Format(PyExc_MemoryError, "Bad value for SMS Format '%s'",
PyErr_Format(PyExc_ValueError, "Bad value for SMS Format '%s'",
s);
return 0;
}
Expand Down Expand Up @@ -498,7 +498,6 @@ char *UDHTypeToString(GSM_UDH type)
if (s == NULL) {
PyErr_Format(PyExc_ValueError,
"Bad value for UDHType from Gammu: '%d'", type);
free(s);
return NULL;
}

Expand Down