fix(typecheck): print warning messages, and fix the unused-variable false positive by gHashTag · Pull Request #2013 · gHashTag/t27

gHashTag · 2026-08-09T07:19:12Z

Two coupled changes: make warnings visible, then fix what visibility immediately exposed.

1. The messages were built and then dropped

typecheck constructed every warning message and threw it away — the OK branch printed only the total, so a warning was unactionable: you could watch the number grow and never learn what it was. The messages were already sitting in result.errors; now they print.

This matters because some of these are real correctness findings downgraded to warnings — a call to an undefined function, and an argument type mismatch. The silence actively hid defects.

2. What visibility exposed: 20 false positives

With the texts visible, tri-net's 788 warnings resolved into two dominant categories — and 20 of the 34 unused-variable warnings were false.

A bare bracket literal ([a0, 99], with no [N]Type{...} prefix) never becomes child nodes: the parser captures the whole bracket body as element TEXT in extra_size. The unused-variable pass walked children only, so every identifier used that way was reported unused. That is the idiomatic "bind the elements to locals, then rebuild the array" pattern:

let a0: u32 = arr[0];
let a1: u32 = arr[1];
if (idx == 0) { return [99, a1]; }
return [a0, 99];

— which reported both a0 and a1 unused. Real instances: health_monitoring::update_health_check, key_management::set_key_slot, cross_layer_optimizer/redundancy_management::set_slot4.

collect_reads now scans the element text as well. It can only add reads, so it removes false warnings and can never introduce one.

Validation

minimal repro: 2 warnings → 0
tri-net corpus: unused-variable 34 → 14 (20 were false), total 788 → 768
all 107 specs still typecheck clean
t27 suite 1537 passed; the single failure (bitnet_layer) is the known environmental iverilog failure, present on master before this change
FROZEN_HASH resealed

Refs #1948

🤖 Generated with Claude Code

github-actions · 2026-08-09T07:19:28Z

PR Dashboard

Generated at: 2026-08-09 07:19:26 UTC

fix(typecheck): print warning messages, and fix the unused-variable false positive #2013 fix(typecheck): print warning messages, and fix the unused-variable false positive | Created: 2026-08-09 | Updated: 2026-08-09 | 12 failing / 21 total
docs(numeric): correct why former_name exists -- the ladder was never published (Refs #2001) #2012 docs(numeric): correct why former_name exists -- the ladder was never published (Refs #2001) | Created: 2026-08-09 | Updated: 2026-08-09 | 0 failing / 24 total
feat(igla): Wave Loop 898 — module-scope [615][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1900 feat(igla): Wave Loop 898 — module-scope [615][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
chore: civilian mesh positioning — drop drone wording (bpsk.t27) #1874 chore: civilian mesh positioning — drop drone wording (bpsk.t27) | Created: 2026-08-07 | Updated: 2026-08-07 | 2 failing / 25 total
feat(igla): Wave Loop 897 — module-scope [613][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1858 feat(igla): Wave Loop 897 — module-scope [613][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
feat(igla): Wave Loop 896 — module-scope [611][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1856 feat(igla): Wave Loop 896 — module-scope [611][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
feat(igla): Wave Loop 895 — module-scope [609][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1854 feat(igla): Wave Loop 895 — module-scope [609][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
feat(igla): Wave Loop 894 — module-scope [607][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1852 feat(igla): Wave Loop 894 — module-scope [607][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
feat(igla): Wave Loop 893 — module-scope [605][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1850 feat(igla): Wave Loop 893 — module-scope [605][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
feat(igla): Wave Loop 892 — module-scope [603][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1847 feat(igla): Wave Loop 892 — module-scope [603][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
feat(igla): Wave Loop 891 — module-scope [601][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1844 feat(igla): Wave Loop 891 — module-scope [601][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 0 failing / 4 total
feat(igla): Wave Loop 890 — module-scope [599][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1842 feat(igla): Wave Loop 890 — module-scope [599][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 0 failing / 4 total
feat(igla): Wave Loop 883 — module-scope [585][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1815 feat(igla): Wave Loop 883 — module-scope [585][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-06 | Updated: 2026-08-06 | 0 failing / 1 total
feat(igla): Wave Loop 882 — module-scope [583][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1813 feat(igla): Wave Loop 882 — module-scope [583][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-06 | Updated: 2026-08-06 | 0 failing / 12 total
feat(igla): Wave Loop 881 — module-scope [581][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1810 feat(igla): Wave Loop 881 — module-scope [581][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-06 | Updated: 2026-08-06 | 0 failing / 12 total

Summary

Status	Count
Total Open PRs	15
PRs with Failing Checks	1
PRs with All Checks Green	14
READY	6
FAILING	1
PENDING	0

Seal Status

⚠️ STALE -- sha256(compiler.rs)=cd2822f290eb != manifest seal=87e5cbd3ad94.
The committed NMSE numbers were certified against an older compiler.rs.
Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

github-actions · 2026-08-09T07:19:28Z

📓 NotebookLM Notebook linked to this PR

Notebook ID: b83263109fb055dc
URL: https://notebooklm.google.com/notebook/b83263109fb055dc

This notebook contains session context, decisions, and artifacts for this work.

…alse positive Two coupled changes: make warnings visible, then fix what visibility immediately exposed. 1. typecheck built every warning message and then dropped it on the floor. The OK branch printed only the total, so a warning was unactionable -- you could watch the number grow and never learn what it was. The messages were already sitting in result.errors; print them. This matters because some of these are real correctness findings downgraded to warnings: a call to an UNDEFINED function, and an argument type mismatch. The silence actively hid defects. 2. With the texts visible, 719 of tri-net's 788 warnings turned out to be one category and 34 another -- and 20 of those 34 were FALSE. A bare bracket literal ([a0, 99], with no [N]Type{...} prefix) never becomes child nodes: the parser captures the whole bracket body as element TEXT in extra_size. The unused-variable pass walked children only, so every identifier used that way was reported unused. That is the idiomatic "bind the elements to locals, then rebuild the array" pattern, e.g. let a0 = arr[0]; let a1 = arr[1]; if (idx == 0) { return [99, a1]; } return [a0, 99]; which reported both a0 and a1 unused. collect_reads now scans the element text as well. It can only ADD reads, so it removes false warnings and can never introduce one. tri-net corpus: unused-variable warnings 34 -> 14 (20 were false), total 788 -> 768, and all 107 specs still typecheck clean. t27 suite 1537 passed; the single failure (bitnet_layer) is the known environmental iverilog failure, present on master before this change. FROZEN_HASH resealed. Refs #1948

github-actions · 2026-08-09T07:24:56Z

PR Dashboard

Generated at: 2026-08-09 07:24:54 UTC

fix(typecheck): print warning messages, and fix the unused-variable false positive #2013 fix(typecheck): print warning messages, and fix the unused-variable false positive | Created: 2026-08-09 | Updated: 2026-08-09 | 16 failing / 22 total
docs(numeric): correct why former_name exists -- the ladder was never published (Refs #2001) #2012 docs(numeric): correct why former_name exists -- the ladder was never published (Refs #2001) | Created: 2026-08-09 | Updated: 2026-08-09 | 0 failing / 24 total
feat(igla): Wave Loop 898 — module-scope [615][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1900 feat(igla): Wave Loop 898 — module-scope [615][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
chore: civilian mesh positioning — drop drone wording (bpsk.t27) #1874 chore: civilian mesh positioning — drop drone wording (bpsk.t27) | Created: 2026-08-07 | Updated: 2026-08-07 | 2 failing / 25 total
feat(igla): Wave Loop 897 — module-scope [613][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1858 feat(igla): Wave Loop 897 — module-scope [613][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
feat(igla): Wave Loop 896 — module-scope [611][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1856 feat(igla): Wave Loop 896 — module-scope [611][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
feat(igla): Wave Loop 895 — module-scope [609][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1854 feat(igla): Wave Loop 895 — module-scope [609][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
feat(igla): Wave Loop 894 — module-scope [607][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1852 feat(igla): Wave Loop 894 — module-scope [607][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
feat(igla): Wave Loop 893 — module-scope [605][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1850 feat(igla): Wave Loop 893 — module-scope [605][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
feat(igla): Wave Loop 892 — module-scope [603][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1847 feat(igla): Wave Loop 892 — module-scope [603][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
feat(igla): Wave Loop 891 — module-scope [601][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1844 feat(igla): Wave Loop 891 — module-scope [601][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 0 failing / 4 total
feat(igla): Wave Loop 890 — module-scope [599][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1842 feat(igla): Wave Loop 890 — module-scope [599][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 0 failing / 4 total
feat(igla): Wave Loop 883 — module-scope [585][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1815 feat(igla): Wave Loop 883 — module-scope [585][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-06 | Updated: 2026-08-06 | 0 failing / 1 total
feat(igla): Wave Loop 882 — module-scope [583][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1813 feat(igla): Wave Loop 882 — module-scope [583][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-06 | Updated: 2026-08-06 | 0 failing / 12 total
feat(igla): Wave Loop 881 — module-scope [581][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1810 feat(igla): Wave Loop 881 — module-scope [581][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-06 | Updated: 2026-08-06 | 0 failing / 12 total

Summary

Status	Count
Total Open PRs	15
PRs with Failing Checks	1
PRs with All Checks Green	14
READY	6
FAILING	1
PENDING	0

Seal Status

⚠️ STALE -- sha256(compiler.rs)=cd2822f290eb != manifest seal=87e5cbd3ad94.
The committed NMSE numbers were certified against an older compiler.rs.
Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

github-actions · 2026-08-09T07:24:57Z

📓 NotebookLM Notebook linked to this PR

Notebook ID: b83263109fb055dc
URL: https://notebooklm.google.com/notebook/b83263109fb055dc

This notebook contains session context, decisions, and artifacts for this work.

gHashTag force-pushed the fix/typecheck-warning-visibility branch from 27e6b90 to 7ef8a30 Compare August 9, 2026 07:24

gHashTag merged commit 533b0ab into master Aug 9, 2026
30 of 32 checks passed

gHashTag deleted the fix/typecheck-warning-visibility branch August 9, 2026 07:27

Navigation Menu

fix(typecheck): print warning messages, and fix the unused-variable false positive - #2013

fix(typecheck): print warning messages, and fix the unused-variable false positive#2013
gHashTag merged 1 commit into
masterfrom
fix/typecheck-warning-visibility

gHashTag commented Aug 9, 2026

Uh oh!

github-actions Bot commented Aug 9, 2026

Uh oh!

github-actions Bot commented Aug 9, 2026

Uh oh!

github-actions Bot commented Aug 9, 2026

Uh oh!

github-actions Bot commented Aug 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

gHashTag commented Aug 9, 2026

1. The messages were built and then dropped

2. What visibility exposed: 20 false positives

Validation

Uh oh!

github-actions Bot commented Aug 9, 2026

PR Dashboard

Summary

Seal Status

Uh oh!

github-actions Bot commented Aug 9, 2026

Uh oh!

github-actions Bot commented Aug 9, 2026

PR Dashboard

Summary

Seal Status

Uh oh!

github-actions Bot commented Aug 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant