fix(gen-verilog): test-block for-loops, no CSE of loop-variant calls, tail expressions - #1986
Merged
Conversation
… tail expressions Refs #1948 Three linked test-block/fn-body defects: - `for i in ..`/`while` in a test block was DROPPED as `// (stmt: StmtForRange)`, silently voiding loop bodies that accumulate assertions. Loops emit now; the loop variable is declared `integer` at the block top. - The call-CSE pass hoisted a call from INSIDE a loop into one temp evaluated once before the loop with an uninitialized index, so the loop tested a constant. predeclare_call_array_tmps no longer recurses into loop bodies -- loop-variant calls are emitted inline per iteration. - A Rust-style tail expression (a fn body ending in a bare expression, no `return`) lowered to a bare `expr;` that iverilog read as an unknown-task enable; it lowers to `<fn> = <expr>;` now. tri-net corpus: icarus 97 -> 98 (m3_multihop). Top-level `if` in test blocks stays dropped as before (asserts inside need the TB assert-lowering -- out of scope, no regression). bridge.v regenerated; unit suite at the single pre-existing red. FROZEN_HASH resealed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
August 8, 2026 22:37
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1948
Three linked test-block/fn-body defects:
for/whilein a test block was dropped as// (stmt: StmtForRange), silently voiding loop bodies that accumulate assertions. Loops emit now; the loop var is declaredinteger.return) lowered to a bareexpr;(unknown-task enable) →<fn> = <expr>;now.tri-net: icarus 97 → 98 (m3_multihop). Top-level
ifin test blocks stays dropped as before (no regression). bridge.v regenerated; unit suite at the single pre-existing red. FROZEN_HASH resealed; NOW.md entries added.🤖 Generated with Claude Code