fix(gen-verilog): declare the tuple-destructure temp in test blocks - #1982
Merged
Conversation
Refs #1948 A test-block `let (a, b) = call()` slices a packed temp (__tup_l{line}), but that temp and its element regs are declared only in emit_local's Decl phase -- the testbench Init-only path skipped it, so the temp was referenced undeclared ("Could not find variable __tup_l242"). The top-of-block declaration pass now emits the tuple-destructure declarations for empty-name/extra_field locals. tri-net corpus: icarus 96 -> 97 (cross_layer_optimizer). bridge.v regenerated; unit suite at the single pre-existing red. FROZEN_HASH resealed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
August 8, 2026 21:49
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1948
A test-block
let (a, b) = call()slices a packed temp (__tup_l{line}), but that temp and its element regs are declared only in emit_local's Decl phase — the testbench Init-only path skipped it, so the temp was referenced undeclared ("Could not find variable __tup_l242"). The top-of-block declaration pass now emits the tuple-destructure decls for empty-name/extra_field locals.tri-net: icarus 96 → 97 (cross_layer_optimizer). bridge.v regenerated; unit suite at the single pre-existing red. FROZEN_HASH resealed; NOW.md entries added.
🤖 Generated with Claude Code