fix(gen-verilog): const-name array sizes; packed literal locals; keyword-safe local names - #1969
Merged
Merged
Conversation
…ord-safe local names Refs #1948 Three linked defects kept the array-driven test-block specs red under icarus: - Const-name array sizes were not resolved: `[u32; HISTORY_SIZE]` (const size) fell back to a 32-bit scalar input while `[u32; 16]` (literal) packed to 512 bits, so a packed local desynced from the 32-bit param and iverilog saw "Array needs an array index". All type strings now resolve const sizes to numerics before packing. - A primitive [T; N] test-block local initialized from an array LITERAL emitted as an unpacked memory, which cannot be passed whole to a packed fn parameter. It packs to a vector now (the concat text path and part-select indexing already support it). - Function-local reg declarations and assignments did not escape reserved words: a local named `config` emitted `reg [511:0] config;`. tri-net corpus: icarus 77 -> 85 (load_predictor, anomaly_detector, auto_config, cache_management, health_dashboard, local_processing, network_orchestrator, integration_framework). No gate regression; bridge.v regenerated. Unit suite at the single pre-existing red. FROZEN_HASH resealed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
August 8, 2026 19:55
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1948
Three linked defects kept array-driven test-block specs red under icarus:
[u32; HISTORY_SIZE]fell back to a 32-bit scalar input while[u32; 16]packed to 512 bits — packed local desynced from the param ("Array needs an array index"). All type strings resolve const sizes to numerics now.reg [511:0] config;).tri-net corpus: icarus 77 → 85; no gate regression; bridge.v regenerated. Unit suite at the single pre-existing red. FROZEN_HASH resealed; NOW.md entries added.
🤖 Generated with Claude Code