Skip to content

fix(parser): BDD-style fns skipped; fpga-smoke fully green - #1966

Merged
gHashTag merged 1 commit into
masterfrom
fix/smoke-tail
Aug 8, 2026
Merged

fix(parser): BDD-style fns skipped; fpga-smoke fully green#1966
gHashTag merged 1 commit into
masterfrom
fix/smoke-tail

Conversation

@gHashTag

@gHashTag gHashTag commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Closes #1960

Closes the fpga-smoke tail the #1941 hardening exposed:

  • fn name() given ... then ... (keyword-style test spelled as a fn, linker.t27) recognized right after the param list, before return-type parsing — else given was eaten as an identifier return type
  • partition.t27: parameter named module (a keyword) → mod_name

fpga-build --smoke generates all 31 modules + wrapper — GREEN again (red since #1941 surfaced silently-dropped match statements / paren-less conditions / BDD forms). tri-net 77-spec icarus gate green; unit suite at the single pre-existing red. FROZEN_HASH resealed; NOW.md entries added.

🤖 Generated with Claude Code

Closes #1960

The #1941 hardening surfaced constructs the parser silently dropped;
this closes the fpga-smoke tail:

- `fn name() given ... then ...` (a keyword-style test spelled as a fn,
  linker.t27) is recognized right after the parameter list, BEFORE
  return-type parsing -- otherwise `given` was consumed as an
  identifier return type and the body-brace check failed
- partition.t27: a parameter named `module` (a keyword) renamed to
  mod_name

fpga-build --smoke now generates all 31 modules + the wrapper and is
GREEN again (it had been red since #1941 exposed the silently-dropped
match statements, paren-less conditions and BDD forms). tri-net's
77-spec icarus gate is green; unit suite at the single pre-existing red.
FROZEN_HASH resealed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@gHashTag
gHashTag enabled auto-merge (squash) August 8, 2026 19:25
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-08 19:25:30 UTC

Summary

Status Count
Total Open PRs 15
PRs with Failing Checks 2
PRs with All Checks Green 13
READY 5
FAILING 2
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=8672ec556e8a != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit 18698d0 into master Aug 8, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fpga-smoke red: mac.t27 pack_trit has a brace expression the parser rejects (surfaced by #1941 hardening)

1 participant