fix(parser): BDD-style fns skipped; fpga-smoke fully green - #1966
Merged
Conversation
Closes #1960 The #1941 hardening surfaced constructs the parser silently dropped; this closes the fpga-smoke tail: - `fn name() given ... then ...` (a keyword-style test spelled as a fn, linker.t27) is recognized right after the parameter list, BEFORE return-type parsing -- otherwise `given` was consumed as an identifier return type and the body-brace check failed - partition.t27: a parameter named `module` (a keyword) renamed to mod_name fpga-build --smoke now generates all 31 modules + the wrapper and is GREEN again (it had been red since #1941 exposed the silently-dropped match statements, paren-less conditions and BDD forms). tri-net's 77-spec icarus gate is green; unit suite at the single pre-existing red. FROZEN_HASH resealed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
August 8, 2026 19:25
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1960
Closes the fpga-smoke tail the #1941 hardening exposed:
fn name() given ... then ...(keyword-style test spelled as a fn, linker.t27) recognized right after the param list, before return-type parsing — elsegivenwas eaten as an identifier return typemodule(a keyword) → mod_namefpga-build --smokegenerates all 31 modules + wrapper — GREEN again (red since #1941 surfaced silently-dropped match statements / paren-less conditions / BDD forms). tri-net 77-spec icarus gate green; unit suite at the single pre-existing red. FROZEN_HASH resealed; NOW.md entries added.🤖 Generated with Claude Code