fix(gen-verilog): SystemVerilog keywords escaped; safe names in decls and part-selects - #1957
Merged
Conversation
… and part-selects Refs #1948 Spec identifiers named bit, byte, priority, sequence or table reached Icarus as keywords from three directions: the reserved-word list only covered Verilog-2001 (bit/byte/priority/sequence are SV keywords Icarus also rejects), the #1894/#1948 testbench declaration passes wrote RAW names (`reg [63:0] bit;` -- 'Syntax error in variable list'), and the packed part-select emissions wrote the raw base name. The SV keyword block joins the reserved list, and every declaration and part-select site goes through verilog_safe_identifier. tri-net corpus: icarus 69 -> 77 passing; bandwidth_allocator, byte_utils, crc16, fault_detection, pattern_predictor, power_monitoring, production_deployment and resource_scheduler join. No gate regression. FROZEN_HASH resealed; only unit red is the pre-existing bitnet_layer. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
August 8, 2026 17:59
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
gHashTag
added a commit
that referenced
this pull request
Aug 8, 2026
…updated (#1958) * fix(gen-verilog): W458 keeps the legacy [N]T binding; unit contracts updated Refs #1948 Follow-up landing the two pieces auto-merge raced past in #1952/#1957: - The W458 array-param exclusion narrows to rust-style [T; N] primitives only: the legacy [N]T spelling keeps its module-array ROM binding contract (array_param_read_emitted asserts it) - nested_return_lowers_as_early_exit's discriminator includes the early-return guard assignment introduced by #1950 Unit suite back to a single pre-existing red (bitnet_layer iverilog). FROZEN_HASH resealed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: NOW entries for the W458 follow-up Refs #1948 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1948
Spec identifiers named
bit/byte/priority/sequence/tablereached Icarus as keywords from three directions: the reserved list only covered Verilog-2001, the #1894/#1948 TB declaration passes wrote raw names (reg [63:0] bit;), and packed part-selects wrote the raw base.SV keyword block added; every declaration and part-select site goes through
verilog_safe_identifier.tri-net corpus: icarus 69 → 77 (bandwidth_allocator, byte_utils, crc16, fault_detection, pattern_predictor, power_monitoring, production_deployment, resource_scheduler join); no gate regression. Only unit red is pre-existing bitnet_layer. FROZEN_HASH resealed; NOW.md entries added.
🤖 Generated with Claude Code