fix(gen-verilog): TB assignments emit for real; packed literals read element text - #1953
Merged
Conversation
…element text Refs #1948 Two testbench-side defects kept every array-driven spec red under icarus even after the fn-side [T; N] packing landed: - Test-block StmtAssign/StmtLocal statements were emitted COMMENTED OUT: every binding built from a call (`array = create(...)`) stayed X in the testbench, so array-driven asserts could never pass. They emit for real now -- the regs come from the #1894 pass and the t27#1948 declaration pass. - The packed array-literal concatenation only read CHILD nodes, but the parser stores list-form element text in extra_size with no children: literals built from parameters or calls rendered as ZEROS (create_path_metrics_array returned {32'd0, 32'd0, 32'd0, 32'd0}). The text path now splits top-level commas and width-casts each element for the concatenation. tri-net corpus: icarus 60 -> 69 passing; adaptive_routing, energy_aware_routing, failure_predictor, health_monitoring, key_management, multipath_routing, network_coding, redundancy_management and trust_manager all join. No gate regression. FROZEN_HASH resealed; only unit red is the pre-existing bitnet_layer. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
August 8, 2026 17:44
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1948
Two TB-side defects kept array-driven specs red even after the fn-side [T; N] packing:
array = create(...)) stayed X; array-driven asserts could never pass. Real emission now (regs from gen-verilog-sim: test-block local bindings emitted as assignments without reg declarations #1894 + gen-verilog TB long tails: typed let-locals get no reg declaration; unsized concat operands; 'Syntax error defining function' class #1948 passes).extra_sizewith no children, so literals built from params/calls rendered as zeros. The text path splits top-level commas and width-casts each element.tri-net corpus: icarus 60 → 69 passing (adaptive_routing, energy_aware_routing, failure_predictor, health_monitoring, key_management, multipath_routing, network_coding, redundancy_management, trust_manager join); no gate regression. Only unit red is pre-existing bitnet_layer. FROZEN_HASH resealed; NOW.md entries added.
🤖 Generated with Claude Code