fix(gen-zig): for-range emits its start expression, not the loop variable - #1943
Merged
Conversation
…able Closes #1942 gen_for_range_stmt wrote node.name (the loop variable) where the range START expression belongs: `for i in 0..10` emitted `for (i..10) |i|`, an undeclared identifier for any range not starting at the variable's own name. Emits children[0] now (and the loop variable goes through zig_ident). Surfaced by transcribing tri-net testbench blocks into executable tests -- the first real for-range uses in the zig corpus. Only unit red is the pre-existing bitnet_layer iverilog test. FROZEN_HASH resealed; NOW.md entries added. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
August 8, 2026 14:18
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1942
for i in 0..10emittedfor (i..10) |i|— gen_for_range_stmt wrote the loop VARIABLE where the range start belongs. Emits children[0] now. Surfaced by the tri-net testbench transcription (first real for-range uses in the zig corpus). Only unit red is pre-existing bitnet_layer. FROZEN_HASH resealed; NOW.md entries added.🤖 Generated with Claude Code