Skip to content

fix(gen-rust): array literals emit elements, not empty vec![] - #1939

Merged
gHashTag merged 1 commit into
masterfrom
fix/rust-array-literal
Aug 8, 2026
Merged

fix(gen-rust): array literals emit elements, not empty vec![]#1939
gHashTag merged 1 commit into
masterfrom
fix/rust-array-literal

Conversation

@gHashTag

@gHashTag gHashTag commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Closes #1938

Same parser-representation gap the Zig and C backends already fixed: ExprArrayLiteral stores element text in extra_size with no children, and the Rust emitter mapped children only — every spec array literal compiled to an empty Vec-typed vec![] (E0308 against a [T; N] return; hit by tri-net's included multipath_routing gen). Emits [a, b, c] / [v; n] from the text now.

Only unit red is pre-existing bitnet_layer (iverilog). FROZEN_HASH resealed; NOW.md entries added.

🤖 Generated with Claude Code

Closes #1938

ExprArrayLiteral keeps its element text in extra_size with no children;
the Rust emitter mapped children only, so every spec array literal
compiled to an empty Vec-typed vec![] -- E0308 against a [T; N] return
(hit by tri-net's included multipath_routing gen). Emit [a, b, c] /
[v; n] from the text, mirroring the Zig and C fixes; the children path
emits [..] as well, matching [T; N] types.

FROZEN_HASH resealed; only unit red is the pre-existing bitnet_layer
iverilog test.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@gHashTag
gHashTag enabled auto-merge (squash) August 8, 2026 12:47
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-08 12:47:14 UTC

Summary

Status Count
Total Open PRs 14
PRs with Failing Checks 1
PRs with All Checks Green 13
READY 5
FAILING 1
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=44c15f58d256 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@gHashTag
gHashTag merged commit 8aa25b7 into master Aug 8, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gen-rust: array literals emit empty vec![] (elements live in extra_size text)

1 participant