fix(gen-rust): array literals emit elements, not empty vec![] - #1939
Merged
Conversation
Closes #1938 ExprArrayLiteral keeps its element text in extra_size with no children; the Rust emitter mapped children only, so every spec array literal compiled to an empty Vec-typed vec![] -- E0308 against a [T; N] return (hit by tri-net's included multipath_routing gen). Emit [a, b, c] / [v; n] from the text, mirroring the Zig and C fixes; the children path emits [..] as well, matching [T; N] types. FROZEN_HASH resealed; only unit red is the pre-existing bitnet_layer iverilog test. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
August 8, 2026 12:47
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1938
Same parser-representation gap the Zig and C backends already fixed: ExprArrayLiteral stores element text in
extra_sizewith no children, and the Rust emitter mapped children only — every spec array literal compiled to an empty Vec-typedvec. Emits[a, b, c]/[v; n]from the text now.Only unit red is pre-existing bitnet_layer (iverilog). FROZEN_HASH resealed; NOW.md entries added.
🤖 Generated with Claude Code