Skip to content

test: add sadd cancellation edge to the cross-target proof - #1884

Merged
gHashTag merged 1 commit into
masterfrom
test/multitarget-cancellation
Aug 7, 2026
Merged

test: add sadd cancellation edge to the cross-target proof#1884
gHashTag merged 1 commit into
masterfrom
test/multitarget-cancellation

Conversation

@gHashTag

@gHashTag gHashTag commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Added a targeted edge to the cross-target proof: gen_pairs now injects ~20% cancellation pairs (v, neg(v)) → sadd exact-cancels to 0, plus near-cancellation. This is the historically buggy magsub path (cycle 17 found a negative-zero bug when the larger operand is negative and the result is exactly 0) and the magsub-normalize hot path. Result: model smul/sadd == the C and Rust emissions bit-exact on the cancellation edge too. Combined with last cycle's extreme-operand coverage, the cross-target proof now spans moderate + extreme + cancellation operands. Refs #1764

gen_pairs now injects ~20% cancellation pairs (v, neg(v)) -> sadd exact-cancels to
0, plus near-cancellation (v, neg(v')). This is the historically buggy magsub path
(cycle 17 negative-zero bug) and the normalize hot path. Result: model smul/sadd ==
the C and Rust emissions bit-exact on the cancellation edge too. Combined with the
extreme-operand coverage, the cross-target proof now spans moderate + extreme +
cancellation operands.

Refs #1764

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-07 16:46:00 UTC

Summary

Status Count
Total Open PRs 13
PRs with Failing Checks 1
PRs with All Checks Green 12
READY 5
FAILING 1
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=4c1aaad5309a != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit 2151e8f into master Aug 7, 2026
18 checks passed
@gHashTag
gHashTag deleted the test/multitarget-cancellation branch August 7, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant