Conversation
SPI only adds the "Written by" prefix and the full stop to the author line it derives from the commit history. A `metadata.authors` value from .spi.yml is rendered verbatim, so the previous value would have shown as a bare fragment next to the other sentences on the package page. The value now carries the prefix and the full stop itself. SPI reads this from the default branch only -- the release manifest is not consulted -- so the change lands whenever SPI next reprocesses main.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata.authorsin.spi.ymlwas set toKojiro Futamura and contributorsin #89. Reading the Swift Package Index server source shows that value would have rendered as a bare fragment.Sources/App/Views/PackageController/GetRoute.Model+ext.swiftadds theWritten byprefix and the full stop only to the line it derives from the commit history:So the value has to be a complete sentence. It now reads
Written by Kojiro Futamura and contributors., and the comment above it records why. TLDExtractSwift carries the same change.The page still shows the old derived line, so this lands before the first render rather than correcting it afterwards.
Notes
Sources/App/Controllers/API/API+PackageController+PackageResult.swiftreads the manifest fromdefaultBranchVersiononly — a release does not carry the author line forward, which is why 4.0.2 updated the "Latest Release" field but left the author line untouched. SPI's own docs put default-branch.spi.ymlchanges at up to 24 hours.Test plan
.spi.ymlparses as valid YAML;metadata.authorsisWritten by Kojiro Futamura and contributors.and the file is 1029 bytes, under SPIManifest's 1500 byte limit and the 200 character cap on the authors string.