Repository navigation
refactor: apply the template numeric lint rules - #84
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Enable complexity, max-depth, max-lines, and max-params as in template-typescript, and split the violating functions without changing behavior. Refs furedea/dotfiles#247 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying furedea-com with
|
| Latest commit: |
6f5e60e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://74837a40.furedea-com.pages.dev |
| Branch Preview URL: | https://refactor-apply-numeric-lint.furedea-com.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
template-typescript と同じ数値系 lint ルール(
complexity10,max-depth2,max-params3,max-lines500)を.oxlintrc.jsonに追加し,既存の違反を振る舞いを変えないリファクタリングで解消しました.disable は追加していません.Refs furedea/dotfiles#247
違反数
complexitymax-paramsmax-depthmax-lines受け入れ条件
file-lengthコマンドが無いため,lefthook は変更なし)詳細
src/integrations/esa.ts:isEsaPostSummaryをhasEsaPostContentとhasEsaPostMetadataに分割.分割前に,検索結果の各フィールドが不正な場合に公開を拒否する振る舞いを固定するテストをsrc/integrations/esa.test.tsに追加.src/data/article.ts:protectFencedBlocksをガード節で平坦化し,閉じフェンス判定をclosesFenceに抽出.convertCaptionsの置換コールバックはキャプチャを rest 引数で受け取るように変更.tests/performance/performance_report.ts:unitWithRangeのmedianとsamplesを 1 つの引数オブジェクトにまとめた.検証
pnpm check(format,lint,typecheck,test 125 件,knip,build,verify:build): 成功lefthook run pre-commit --all-files: 成功pnpm check:e2e: ローカルのサンドボックス内では preview サーバーへの接続がタイムアウトして実行できず.CI で確認する.🤖 Generated with Claude Code