Repository navigation
fix: pin macOS host names per darwin configuration - #155
Merged
Merged
Conversation
With HostName unset, macOS adopts the DHCP/reverse-DNS name of the current network. On the university network the prompt therefore showed mge instead of mbp. Set networking.hostName, localHostName, and computerName per host via mkDarwinConfiguration. A host-configuration contract guards the names of both hosts. Refs #154 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
flake.nix:mkDarwinConfigurationtakes ahostName(mbp,mba) and passes it throughspecialArgs.nix/darwin/default.nix: setsnetworking.hostName,networking.localHostName, andnetworking.computerNamefrom it. WithHostNameunset, macOS adopted the DHCP/reverse-DNS name of the current network, so the prompt showedmgeon the university network.nix/checks.nix: newhost-names-pinnedcontract inhost-configurationasserting the three names for both hosts.Closes #154
Verification
nix build .#checks.aarch64-darwin.host-configuration: failed withhost-names-pinnedbefore the change (Red), passes after (Green).verification_session.py verify): passed (bats 13 passed, pytest 3 passed).deadnixandnixfmt --checkon the edited files: clean. lefthook pre-commit and commitlint passed at commit time.darwin-rebuild switch. Apply on each machine withsudo darwin-rebuild switch --flake .#mbp(or.#mba) and confirmscutil --get HostName.Departures from the plan
None. Note that
mbaalso gets its names pinned tombaso both hosts share the same mechanism.🤖 Generated with Claude Code