fix(powershell): tolerate quoted/padded FUNDSXML_SCHEMA_DIR#20
Merged
Conversation
cmd's `set VAR="x"` keeps the quotes in the value; the stray " is an illegal Windows path character and made Test-Path throw before the not-found check, aborting validation. Trim surrounding quotes and whitespace from the env var so the documented corporate escape hatch tolerates this common shell mistake. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
$env:FUNDSXML_SCHEMA_DIRwas set via cmd'sset VAR="C:\...", whichkeeps the double quotes literally in the value. A
"is an illegalWindows path character, so
Test-Paththrew anArgumentExceptionbefore the "not found" check — aborting validation entirely.
Fix
The env var is the documented "corporate/offline escape hatch", so it
should tolerate this very common shell mistake. Trim surrounding quotes
(
"/') and whitespace from the value before using it as a path.No behavior change for correctly-set values.
🤖 Generated with Claude Code