Repository navigation
fix: grant the pipeline deploy step keda.sh ScaledObjects and Trigger Authentications - #265
Merged
Merged
Conversation
…Authentications Since knative/func#4069 func's keda deployer reads ScaledObjects on every deploy, to catch a switch between the http and kafka scalers, and creates ScaledObjects and TriggerAuthentications for kafka triggers. The deploy step of the on-cluster build runs that deployer as the namespace's default service account, with the Role this operator creates. That Role had no keda.sh rules, so, as knative/func#4077 describes for func's own roles, every keda deploy is refused. The E2E keda jobs have failed on every PR since 2026-10-05. The deploy step runs ghcr.io/knative/func-utils:v2, a tag func republishes from its main branch, so the change reached the operator without a func bump. Grant the verbs func grants itself in knative/func#4077. The operator's ClusterRole needs the same rule, or it may not create the Role. Existing Roles get the rule on the next rebuild in their namespace, because ensureDeployFunctionRole rewrites rules that differ.
maschmid
enabled auto-merge (squash)
October 13, 2026 09:19
|
/lgtm Looks great, thanks @gauron99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since knative/func#4069 func's keda deployer reads ScaledObjects on every deploy, to catch a switch between the http and kafka scalers, and creates ScaledObjects and TriggerAuthentications for kafka triggers. The deploy step of the on-cluster build runs that deployer as the namespace's default service account, with the Role this operator creates. That Role had no keda.sh rules, so, as knative/func#4077 describes for func's own roles, every keda deploy is refused. The E2E keda jobs have failed on every PR since 2026-10-05.
The deploy step runs ghcr.io/knative/func-utils:v2, a tag func republishes from its main branch, so the change reached the operator without a func bump.
Grant the verbs func grants itself in knative/func#4077. The operator's ClusterRole needs the same rule, or it may not create the Role. Existing Roles get the rule on the next rebuild in their namespace, because ensureDeployFunctionRole rewrites rules that differ.