fix(deps): bump Testcontainers to 4.14.0 to clear the SSH.NET advisory - #1369
Open
maxiar wants to merge 3 commits into
Open
fix(deps): bump Testcontainers to 4.14.0 to clear the SSH.NET advisory#1369maxiar wants to merge 3 commits into
maxiar wants to merge 3 commits into
Conversation
Testcontainers 4.11.0 depends on SSH.NET 2025.1.0, which carries a high-severity advisory (GHSA-q939-rpr3-3284: ScpClient recursive download allows arbitrary file write via server-controlled SCP filenames). NuGetAudit raises NU1903 and, under TreatWarningsAsErrors, fails restore for Integration.Tests and Integration.Middleware.Tests. Testcontainers 4.14.0 already depends on the patched SSH.NET 2026.0.0, so bumping the three Testcontainers.* packages clears the advisory without a transitive pin that would later need removing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Testcontainers 4.11.0 depends on SSH.NET 2025.1.0, which carries a high-severity advisory (GHSA-q939-rpr3-3284: ScpClient recursive download allows arbitrary file write via server-controlled SCP filenames). NuGetAudit raises NU1903 and, under TreatWarningsAsErrors, fails restore for Integration.Tests and Integration.Middleware.Tests. Testcontainers 4.14.0 already depends on the patched SSH.NET 2026.0.0, so bumping the three Testcontainers.* packages clears the advisory without a transitive pin that would later need removing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…otnet-starter-kit into fix/testcontainers-ssh-net-advisory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dotnet restorefails forIntegration.TestsandIntegration.Middleware.Tests:SSH.NETis not a direct dependency, which is why it does not appear inDirectory.Packages.props. It arrives transitively:GHSA-q939-rpr3-3284 (high) — ScpClient recursive download allows arbitrary file write via server-controlled SCP filenames. Affects
<= 2025.1.0; first patched in2026.0.0.Fix
Bump the three
Testcontainers.*packages4.11.0→4.14.0. Testcontainers 4.14.0 already depends on the patchedSSH.NET2026.0.0, so the advisory clears without adding a transitive pin under the "Transitive security pins" group — one less pin to remember to remove later.Verification
dotnet restore src/FSH.Starter.slnx— succeeds, all 51 projects, no NU1903.dotnet buildon both integration test projects — 0 warnings / 0 errors underTreatWarningsAsErrors.Notes
🤖 Generated with Claude Code