fix(cli,template): drop the unimplemented --db sqlserver option#1265
Merged
Conversation
The CLI `--db` option and the template's `db` choice symbol advertised SQL Server, but selecting it had NO effect -- the generated app was always PostgreSQL (provider, connection string, and the sole `*.Migrations.PostgreSQL` project). Shipping a no-op option in the grand release would mislead users, so drop it; the scaffold now offers only what actually works (PostgreSQL). Removed: the `--db` CLI option + its interactive prompt (ResolveDatabaseAsync), the `db` template symbol, and the `--db sqlserver` example. The backend's latent multi-provider abstraction (DbProviders / OptionsBuilderExtensions) is left untouched, so real SQL Server support can be added later without re-plumbing. Found while smoke-testing the distribution for release. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The smoke test scaffolded with `dotnet new fsh ... --db postgresql`, which now
fails ("unknown option --db") because this PR removed the db template symbol.
Drop the flag from both the full and minimal scaffold steps.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during the pre-release smoke test.
--db sqlserver(CLI option + templatedbchoice) advertised SQL Server but did nothing — the generated project was always PostgreSQL (providerPOSTGRESQL, Postgres connection string, only a*.Migrations.PostgreSQLproject). Thedbsymbol had no conditional wiring at all.Rather than ship a misleading option in the grand release, this removes it so the scaffold only offers what works:
--dboption, the interactive DB prompt, and the--db sqlserverexample.dbchoice symbol.The backend's latent provider abstraction (
DbProviders,OptionsBuilderExtensions) is left intact, so proper SQL Server support can be added later without re-plumbing.Verified: CLI builds,
fsh new --helpno longer lists--db, and a fresh pack→install→scaffold→build (no--db) produces a clean PostgreSQL app (build 0/0).🤖 Generated with Claude Code