fix(cli): template detection in doctor/info + drop obsolete Aspire workload check#1257
Merged
Conversation
…spire check - `fsh doctor` and `fsh info` reported "Template: not installed" even when it was, because detection parsed `dotnet new list` (which has no version column). Read `dotnet new uninstall` instead, which lists the package id + version. - `fsh doctor` recommended `dotnet workload install aspire`, but Aspire is no longer a workload (NuGet SDK since .NET 9). Removed the obsolete check. Verified: `fsh doctor` now shows FSH Template PASS v10.0.0 and no Aspire row; `fsh info` shows the template version. Builds clean with -warnaserror.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cosmetic CLI bugs found during pre-release verification (the first thing devs see when they run
fsh doctor/fsh info):dotnet new list fsh, which has no version column, so it always returned null. Now readsdotnet new uninstall(lists the package id +Version:), with a folder-install fallback.fsh doctorrandotnet workload listand told users todotnet workload install aspire, but Aspire has been a NuGet SDK (no workload) since .NET 9. Removed the check.Before / after
fsh doctorAspire Workload WARN Run: dotnet workload install aspire+FSH Template WARN Not installedFSH Template PASS v10.0.0Builds clean with
-warnaserror; verifieddoctor+infoagainst an installed template.🤖 Generated with Claude Code