Fix localized homepage title overflow on mobile - #113
Merged
Conversation
LakshmanTurlapati
marked this pull request as ready for review
August 10, 2026 16:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
white-space: nowrapreintroductionRoot cause
The mobile hero forced every locale onto one line and sized the title using an English-specific width estimate. German, Spanish, and unbroken CJK text could exceed the content box, while the hero clipped the overflow.
FSB mobile validation
Validated the prerendered localized homepages through FSB in exact 390 × 844 CSS-pixel viewports:
Every locale reported
scrollWidth === clientWidth === 390and title bounds fully inside the viewport.English, Spanish, and German
Japanese, Simplified Chinese, and Traditional Chinese
Verification
SKIP_BUILD=1 node tests/showcase-build-smoke.test.js— 86 passednode tests/showcase-angular-foundation.test.js— 51 passednpm --prefix showcase/angular run build— 54 localized routes prerenderednpm --prefix showcase/angular run verify:hreflang— 541 passed