fix: resolve agent CLIs outside inherited PATH - #491
Conversation
|
Apologies for the long silence — the delay was ours, not a reflection of the PR. The change itself holds up. Keeping PATH-resolved wrappers and shims late-bound in the child shell is the right shape, the fallback locations are the ones that actually matter across macOS, Linux, and Git Bash, and covering the three executable forms rather than assuming one is the part that makes it portable instead of merely working locally. The added tests exercise the resolution order directly, which is what we would have asked for. Two housekeeping items, both on us. The required check names changed after this PR last ran. The bats suite is now split into parallel shards, and the required context is a summary job named While rebasing we will also restore the executable bit on On scope, your framing is the correct one and we want it on the record: One thing that is genuinely blocking, and it is not about quality. The fallback resolution order is a user-facing contract — once shipped, people depend on which location wins — so it counts as an interface addition here, and interface additions need fujibee to examine the design himself rather than being merged on review alone. That look is still pending on our side. It is not waiting on anything from you, and it is not a judgement on the PR; we would rather tell you where it actually stands than leave it quiet again. |
Summary
Refs #397
Verification
npx --yes bats --print-output-on-failure tests/test_spawn.bats(75/75)npx --yes bats --print-output-on-failure --filter '[Ww]indows fallback' tests/test_spawn.bats(4/4)bash -n scripts/spawn.shgit diff --check origin/main...HEADReview
/simplify findings: nothing foundship