Repository navigation
Return an empty read_block when the offset is past EOF - #2261
Merged
martindurant merged 2 commits intoOct 14, 2026
Merged
Conversation
Signed-off-by: Xucheng Zhou <aden1350@outlook.com>
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a block beyond EOF can turn the requested length into a negative number. For example,
fs.read_block(path, 5, 1)on a three-byte local file passes-2to the file'sread()and raisesValueError, whereas the memory backend returns an empty block. The same problem affectslength=Noneand delimiter reads.Clamp the remaining length to zero. Reads within the file and delimiter alignment remain unchanged. Add local/memory regression cases for in-file, EOF, one-byte-past and two-byte-past offsets, with finite/None lengths and with/without a delimiter.
Validation against master
94afb3f6:This is distinct from #2256's
split_beforehandling and does not alter that utility branch. AI-assisted, independently reproduced with actual local files and the public filesystem API. No cloud-service or full-CI qualification is claimed.