Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transaction state belongs to the filesystem instance. When two threads share that instance and overlap transactions, one transaction can interfere with the other's pending writes. The transaction documentation currently has no warning about this.
Add the warning and explain how to use separate instances with
skip_instance_cache=True. This follows the maintainer's recommendation in #180 to document the limitation. The changelog entry records the clarification; there is no runtime change.Checked locally on Windows with Python 3.12:
git diff --checkpass.The full documentation site, cloud backends, downstream projects and other OS/Python combinations were not tested.
Refs #180.