Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReferenceFileSystem.find()matches raw string prefixes, sofind("dataset")includesdataset-other/file, andfind("dataset/file")includesdataset/file-extra. A missing path such asdatacan also return entries fromdataset. Both the name list and the detailed result are affected.This also gives
FSMapphantom keys: a mapper rooted atdatasetexposes-other/filefrom its sibling, and its length is inflated. The directory-awarefind(..., withdirs=True)path already keeps the correct boundary.Match either the exact path or a descendant beginning with
path + "/". Normalize the input before testing for the root soreference://continues to list all references. The optimized reference scan remains in place.Regression tests cover directories, trailing slashes, protocol-qualified paths, exact filenames, missing prefixes, root inputs, both detail modes, and mapper keys/length/values.
Validation on Windows / Python 3.14.3:
26ebc63: all 17 new cases passed again; neither changed file differs between the original and current bases.git diff --check, passed.The complete suite was not run. The related selection includes local FTP fixtures and an expected-failure external FTP test.