Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a missing target with
filecachein append mode raisesTypeError: cannot unpack non-iterable bool objectinstead of creating the file.WholeFileCacheFileSystem._open()allows a missing remote file through the append branch, then unconditionally unpacks the absent cache entry.simplecachealready permits this operation.Only unpack and validate cached metadata when an entry exists, allowing new append targets to reach the existing
LocalTempFilecreation path. Existing read/update and partially cached file handling is preserved.The regression covers
abanda+bwith memory and local targets, comparingfilecacheandsimplecache. It checks creation, append position, update reads, upload on close, and a subsequent append.Validation on Windows / Python 3.14.3:
filecachemissing-target opens.git diff --checkpassed.