Remove conditionless reduction hint#871
Merged
Merged
Conversation
For records with different data but that data are not literal constants.
webwarrior-ws
force-pushed
the
hints-bug-ignore
branch
from
July 14, 2026 08:25
42c4fe8 to
0b7e2f2
Compare
Collaborator
|
When you perform a 'git revert' command, git automatically injects the commit hash in the commit msg, why did you remove the commit hash from it? |
This reverts commit d0f34e0. Hint introduced in that commit caused false positives on records, which are hard to fix.
Fixing it would take a lot of work since AbstractSyntaxArray.getHashCode function would have to be defined for all expression types (there are about 60 of them).
webwarrior-ws
force-pushed
the
hints-bug-ignore
branch
from
July 14, 2026 08:36
42c4fe8 to
d0d3408
Compare
Contributor
Author
Added commit hash back to the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed conditionless reduction ("if x then y else y ===> y") hint because it caused false positives on records.
Fixing it would take a lot of work since AbstractSyntaxArray.getHashCode function would have to be defined for all expression types (there are about 60 of them).
A test with
[<Ignore>]attribute was added as an example of such false positive.