perf(Core/SourceLength): Change Substring to Span#870
Merged
Conversation
Collaborator
|
LGTM; just respect the 50char max limit for commit msg title (otherwise it overflows into next line), e.g. |
Creating two substrings and then joining them allocates 3 strings, but creating two spans and concatenating those only allocates one, which can be a substantial saving on large files. Running the benchmarks with the extended set of 'self check' rules enabled gives me - Before: | Method | Mean | Error | StdDev | Gen0 | Gen1 | Gen2 | Allocated | |--------------- |--------:|---------:|---------:|-----------:|-----------:|----------:|----------:| | LintParsedFile | 1.467 s | 0.0287 s | 0.0282 s | 36000.0000 | 12000.0000 | 3000.0000 | 622 MB | After: | Method | Mean | Error | StdDev | Gen0 | Gen1 | Gen2 | Allocated | |--------------- |--------:|---------:|---------:|-----------:|-----------:|----------:|----------:| | LintParsedFile | 1.433 s | 0.0085 s | 0.0076 s | 35000.0000 | 11000.0000 | 2000.0000 | 588.75 MB |
Numpsy
force-pushed
the
multilinew_strip_span
branch
from
July 14, 2026 20:48
e07a4ed to
bacd5ea
Compare
Numpsy
changed the title
Numpsy
marked this pull request as ready for review
July 14, 2026 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at this when I opened #869 - leaving it as a draft for now due to that
Creating two substrings and then joining them allocates 3 strings, but creating two spans and concatenating those only allocates one, which can be a substantial saving on large files.
Running the benchmarks with the extended set of 'self check' rules enabled gives me -
Before:
After: