Skip to content

Added warning for clippy:pedantic and clippy::perf. Fixed issues.#21

Open
martinfrances107 wants to merge 1 commit into
fslabs:mainfrom
martinfrances107:clippy_perf_pedantic
Open

Added warning for clippy:pedantic and clippy::perf. Fixed issues.#21
martinfrances107 wants to merge 1 commit into
fslabs:mainfrom
martinfrances107:clippy_perf_pedantic

Conversation

@martinfrances107

@martinfrances107 martinfrances107 commented Jun 6, 2026

Copy link
Copy Markdown

What I did :-
add warning
ran cargo clippy --fix
manually inspected the changes .. all ok

The effect is all minor changes

#[must_use]

Improved API design ... users will now be bumped on the nose if they are using the API incorrectly.

Also in some places casting becomes explicit.

-        va[0] as Real + (vb[0] as Real - va[0] as Real) * t,
-        va[1] as Real + (vb[1] as Real - va[1] as Real) * t,
-        va[2] as Real + (vb[2] as Real - va[2] as Real) * t,
+        Real::from(va[0]) + (Real::from(vb[0]) - Real::from(va[0])) * t,
+        Real::from(va[1]) + (Real::from(vb[1]) - Real::from(va[1])) * t,
+        Real::from(va[2]) + (Real::from(vb[2]) - Real::from(va[2])) * t,

@fslabs-bot

fslabs-bot Bot commented Jun 6, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fslabs-bot

fslabs-bot Bot commented Jun 6, 2026

Copy link
Copy Markdown

Welcome @martinfrances107! It looks like this is your first PR to fslabs/PoissonReconstruction 🎉

@fslabs-bot fslabs-bot Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant