Removed reliance on pelicanq fork of fastapi-users#525
Open
georgelgeback wants to merge 7 commits into
Open
Conversation
…naccurate comment
…essionProxy, the async wrapper for fastapi-users
georgelgeback
marked this pull request as ready for review
July 25, 2026 17:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~ 400 LOC of this PR is tests, so the changes were not as large as I had expected before starting.
This PR uses a pretty unsatisfying method of wrapping the poor async fastapi-users so that we can interact with it in a non-async manner. That wrapper is pretty vibe coded, not my area of expertise (though there are tests and reviews consistently claim it's fine). Allegedly you could also choose to have two connections to the database, one sync and one async, and then rewrite user management, permission management and auth using async. You could also rewrite the entire backend to be async, but both of these would need quite a lot of work (no more direct references to db objects, update all the tests, querying in a different way etc.) so I thought this was the best alternative.
I think there could also be room for forking our own version of fastapi-users and only removing the async parts, if we really don't want the async wrapper.
Since this changes how permissions are communicated to PermissionWall in the frontend, this PR needs to be pushed to prod at the same time as the corresponding frontend one: